Skip to content

feat: codex qol updates #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 21, 2025
Merged

feat: codex qol updates #348

merged 20 commits into from
Aug 21, 2025
+251 −215

Conversation

DevelopmentCats
Copy link
Contributor

Description

  • Removed variables for hardcoded configuration options, and replaced with variables for base config, and additional mcp servers.
  • Set module defaults so that this will run with minimal module configuration for tasks, while allowing further configuration if needed by the user for codex through the base configuration.
  • Updated tests for expected responses and new configuration options.
  • Move all codex related files outside of project folder.

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder-labs/modules/codex
New version: v1.1.0
Breaking change: [X] Yes [ ] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@DevelopmentCats
refactor: streamline Codex configuration variables and update install…
0c5d450 
…ation script for new options
@DevelopmentCats
test: update codex configuration tests with new base config and addit…
0fdb5aa 
…ional MCP server settings
@DevelopmentCats
docs: update README for Codex module with updated usage examples and …
223e21e 
…configuration details
@DevelopmentCats
chore: update Codex module version to 1.0.2 in README
451f488
@DevelopmentCats
refactor: update defaults to fit tasks behaviour, and make mcp env a …
730c023 
…single liner
@DevelopmentCats
feat: add writable_roots to minimal default configuration
44d7dd7
@DevelopmentCats
feat: update writable_roots in minimal config and manage AGENTS.md fo…
c0ad3e1 
…r instruction prompts
@DevelopmentCats
feat: update AGENTS.md path to ~/.codex directory and enhance README …
50e5fdb 
…with default configuration details
@DevelopmentCats
chore: polish and cleanup
700789e
@DevelopmentCats
feat: update README to include sandbox_mode for containerized workspaces
212a62d
@DevelopmentCats
chore: final cleanup, and updates in tests
f01ea69
@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 01:46
Copilot
Copilot AI reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Codex module for better usability and configuration management. It simplifies variable names, improves defaults, and consolidates configuration files outside the project directory.

  • Replaced granular configuration variables with base_config_toml and additional_mcp_servers for more flexible configuration
  • Set secure defaults to enable minimal configuration while supporting advanced customization
  • Moved all Codex-related files from the project directory to the ~/.codex directory

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
main.tf Consolidated configuration variables and updated variable descriptions with better defaults
scripts/install.sh Refactored configuration generation logic and moved AGENTS.md to ~/.codex directory
scripts/start.sh Improved logging output formatting and updated comments for clarity
main.test.ts Updated tests to reflect new configuration structure and file locations
README.md Updated documentation to reflect new configuration approach and examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

matifali
matifali previously approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and LGTM.

@matifali matifali enabled auto-merge (squash) August 21, 2025 04:09
@matifali matifali disabled auto-merge August 21, 2025 04:09
@DevelopmentCats @matifali
Update README.md
49ef776 
Co-authored-by: Atif Ali <[email protected]>
DevelopmentCats and others added 3 commits August 20, 2025 23:17
@DevelopmentCats @matifali
Update README.md
b7db5fb 
Co-authored-by: Atif Ali <[email protected]>
@DevelopmentCats @matifali
Update README.md
b4f453a 
Co-authored-by: Atif Ali <[email protected]>
@DevelopmentCats @matifali
Update README.md
a630350 
Co-authored-by: Atif Ali <[email protected]>
matifali
matifali previously approved these changes Aug 21, 2025
View reviewed changes
matifali
matifali reviewed Aug 21, 2025
View reviewed changes
35C4n0r
35C4n0r previously approved these changes Aug 21, 2025
View reviewed changes
@DevelopmentCats DevelopmentCats dismissed stale reviews from 35C4n0r and matifali via a271751 August 21, 2025 15:33
@DevelopmentCats
Copy link
Contributor Author

@matifali can you re-approve I updated that last alert to gfm style

matifali
matifali previously approved these changes Aug 21, 2025
View reviewed changes
@matifali matifali added the version:major Add to PRs requiring a major version upgrade label Aug 21, 2025
@github-actions GitHub Actions
Copy link

❌ Version Bump Validation Failed

Bump Type: major

Module versions need to be updated but haven't been bumped yet.

Required Actions:

  1. Run the version bump script locally: ./.github/scripts/version-bump.sh major
  2. Commit the changes: git add . && git commit -m "chore: bump module versions (major)"
  3. Push the changes: git push

Script Output:

🔍 Detecting modified modules...
Found modules:
registry/coder-labs/modules/codex

📦 Processing: coder-labs/codex
Found git tag: release/coder-labs/codex/v1.0.1 (v1.0.1)
Current version: 1.0.1
New version: 2.0.0
Updating version references for coder-labs/codex in registry/coder-labs/modules/codex/README.md

🔧 Running formatter to ensure consistent formatting...

📋 Summary:
Bump Type: major

Modules Updated:

- coder-labs/codex: v1.0.1 → v2.0.0

READMEs Updated:

- coder-labs/codex

✅ Version bump completed successfully!
📝 README files have been updated with new versions.

Next steps:
1. Review the changes: git diff
2. Commit the changes: git add . && git commit -m 'chore: bump module versions (major)'
3. Push the changes: git push

Please update the module versions and push the changes to continue.

@DevelopmentCats
Copy link
Contributor Author

last time I swear lol @matifali

@DevelopmentCats DevelopmentCats merged commit d6ae51f into main Aug 21, 2025
4 checks passed
@DevelopmentCats DevelopmentCats deleted the cat/codex-qol branch August 21, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@matifali matifali matifali approved these changes

@35C4n0r 35C4n0r 35C4n0r left review comments

Assignees
No one assigned
Labels
version:major Add to PRs requiring a major version upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DevelopmentCats @matifali @35C4n0r